Skip to content

backport #830 to rust-miniscript 10.x #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2025

Conversation

apoelstra
Copy link
Member

Just the logic fix; the error refactoring doesn't apply.

apoelstra added 3 commits July 2, 2025 17:10
When deriving keys we refuse to allow multipath keys. We should
forbid them when directly constructing them at all.
@apoelstra apoelstra force-pushed the 2025-07-ddkey-0.10.x branch from c213ab2 to 780d6bc Compare July 2, 2025 17:37
@apoelstra
Copy link
Member Author

Successfully ran my local CI on 780d6bc

@apoelstra
Copy link
Member Author

This one is good to go once I have an ACK from you @sanket1729 . The 11.x one I am still hacking on my local CI, but you can see from the range-diff that this PR and #832 are identical, so if one is good then the other should be too.

I will do some followup PRs, maybe tomorrow, which try to fix CI on 9.x, 10.x, 11.x and 12.x, since all these versions are used by software on crates.io.

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 780d6bc.

Tested on my local machine on stable.

@apoelstra apoelstra merged commit 73473b5 into rust-bitcoin:release-10.x Jul 5, 2025
5 of 17 checks passed
@apoelstra apoelstra deleted the 2025-07-ddkey-0.10.x branch July 5, 2025 02:50
@apoelstra
Copy link
Member Author

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants